Use IBuildDependencyProjectReferencesService to read projects references for CPS based packages.config projects #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
force-pushed
the
dev-nkolev92-addCpsProjectSystemServices
branch
from
4104470 to
c735a9d
Compare
davkean
reviewed
Aug 18, 2021
...ents/NuGet.PackageManagement.VisualStudio/ProjectServices/CpsProjectSystemReferenceReader.cs
Show resolved
Hide resolved
davkean
reviewed
Aug 18, 2021
...ents/NuGet.PackageManagement.VisualStudio/ProjectServices/CpsProjectSystemReferenceReader.cs
Outdated
Show resolved
Hide resolved
nkolev92
force-pushed
the
dev-nkolev92-addCpsProjectSystemServices
branch
from
f8c16fb to
01997dd
Compare
davkean
reviewed
Aug 18, 2021
...ents/NuGet.PackageManagement.VisualStudio/ProjectServices/CpsProjectSystemReferenceReader.cs
Show resolved
Hide resolved
nkolev92
force-pushed
the
dev-nkolev92-addCpsProjectSystemServices
branch
2 times, most recently
from
9d6168c to
4c608a9
Compare
|
Can you please take another look? Thanks! @NuGet/nuget-client I need a review from you as well. |
davkean
reviewed
Aug 31, 2021
...ents/NuGet.PackageManagement.VisualStudio/ProjectServices/CpsProjectSystemReferenceReader.cs
Outdated
Show resolved
Hide resolved
davkean
approved these changes
Aug 31, 2021
nkolev92
force-pushed
the
dev-nkolev92-addCpsProjectSystemServices
branch
from
4c608a9 to
07ecf25
Compare
|
@NuGet/nuget-client Can someone take a look please?🔔 |
zivkan
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11162
Regression? Last working version:
Description
There's a restore time UI delay:
UIDelay: nuget.packagemanagement.visualstudio.dll!NuGet.PackageManagement.VisualStudio.VsCoreProjectSystemReferenceReader+d__
It happens when mixed solutions are used, ones that have PackageReference projects & legacy managed projects & native projects.
The walk that we run in
NuGet.Client/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/ProjectServices/VsCoreProjectSystemReferenceReader.cs
Line 54 in c1a0597
The fix is to use a CPS specific API which is free threaded.
Note that there's currently a bug with this API: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1374627, which is being fixed as we speak.
Second part of this UI delay will be fixed in NuGet/Home#11163.
cc @lifengl @davkean
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Finally there's a bug, which means it'll be a while until we can add an E2E/Apex test: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1374627
Documentation